Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24459 )
Change subject: IMPALA-14787: Add support for Redhat 10 and SLES 16 ...................................................................... Patch Set 13: (5 comments) http://gerrit.cloudera.org:8080/#/c/24459/13/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/24459/13/bin/bootstrap_system.sh@90 PS13, Line 90: 8 or 9 > Nit: add 10 here Done http://gerrit.cloudera.org:8080/#/c/24459/10/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/24459/10/bin/bootstrap_toolchain.py@86 PS10, Line 86: OsMapping("sles12", "ec2-package-sles-12") > Maybe we can remove SLES 12 as well Done http://gerrit.cloudera.org:8080/#/c/24459/10/bin/impala-config-java.sh File bin/impala-config-java.sh: http://gerrit.cloudera.org:8080/#/c/24459/10/bin/impala-config-java.sh@22 PS10, Line 22: Redhat 10 only has Java 21 or above > Does this mean that all the below options would actually fail on Red Hat 10 If someone specifies IMPALA_JDK_VERSION < 21 on Redhat 10, it will fail. We didn't guard against this previously and the error messages from bin/bootstrap_system.sh are fine. I think we can skip it. This particular setting only impacts our test jobs. That said, we don't support building on JDK 21 and running on JDK 17. If someone wants to build our code in a way that is compatible with JDK 17, they must specify JAVA_HOME pointing to JDK 17 for their build. http://gerrit.cloudera.org:8080/#/c/24459/13/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/24459/13/bin/impala-config.sh@312 PS13, Line 312: 9 > This should be 10 Good point, done http://gerrit.cloudera.org:8080/#/c/24459/12/bin/jenkins/all-tests.sh File bin/jenkins/all-tests.sh: http://gerrit.cloudera.org:8080/#/c/24459/12/bin/jenkins/all-tests.sh@35 PS12, Line 35: # that don't install ninja. : export IMPALA_MAKE_CMD=${IMPALA_MAKE_CMD:-ninja} : > This is tracked by IMPALA-14756. Reading IMPALA-14756, it is just too complicated. Ninja belongs in the toolchain. I need it there for LLVM anyway. -- To view, visit http://gerrit.cloudera.org:8080/24459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50acc5fbb4968e4310c4f84dde1d5b931b0385ec Gerrit-Change-Number: 24459 Gerrit-PatchSet: 13 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 17 Jun 2026 23:19:42 +0000 Gerrit-HasComments: Yes
