Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24483
to look at the new patch set (#5).
Change subject: IMPALA-15110: Change the overridden methods in Catalog after
HIVE-26537
......................................................................
IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
were overridden in MetastoreServiceHandler and
CatalogMetastoreServiceHandler, which are instantiated in
CatalogHmsSyncToLatestEventIdTest. Due to this, requests from a
HiveMetaStoreClient were routed to the methods for which there was no
implementation in Impala, causing this Java test to fail. This patch
fixed the issue by renaming those overridden methods in Impala.
After renaming those overridden methods in Impala, we also had to fix
some end-to-end tests in test_metastore_service.py in which the
catalog server is started with "--start_hms_server=true" so that the
Hive MetaStore client will submit the requests to the renamed API's.
Testing:
- Verified that CatalogHmsSyncToLatestEventIdTest is fixed with this
patch.
- Verified that the tests in test_metastore_service.py in which the
catalog server is started with "--start_hms_server=true" are passed
with this patch.
Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
---
M fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
M
fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M
fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java
M
fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java
M tests/custom_cluster/test_metastore_service.py
6 files changed, 100 insertions(+), 65 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/24483/5
--
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 5
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
