Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after 
HIVE-26537
......................................................................


Patch Set 5:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
File fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java:

http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java@50
PS5, Line 50: import org.apache.hadoop.hive.metastore.api.FieldSchema;
unused import: org.apache.hadoop.hive.metastore.api.FieldSchema


http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
File 
fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java:

http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@57
PS5, Line 57: import org.apache.hadoop.hive.metastore.api.PrincipalType;
unused import: org.apache.hadoop.hive.metastore.api.PrincipalType


http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java
File fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java:

http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java@41
PS5, Line 41: import org.apache.hadoop.hive.metastore.api.PrincipalType;
unused import: org.apache.hadoop.hive.metastore.api.PrincipalType



--
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 5
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Mon, 22 Jun 2026 21:41:04 +0000
Gerrit-HasComments: Yes

Reply via email to