Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24403 )
Change subject: IMPALA-14702: Add ability to build against Google Tcmalloc ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/24403/9/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/24403/9/be/src/common/global-flags.cc@130 PS9, Line 130: googletcmalloc_max_per_cpu_cache_size > Wouldn't it be better to get a total in the flag and divide it with the num The per-CPU value automatically uses more memory on larger systems and less memory on smaller systems. It's one to one with the Google TCMalloc configuration parameter. I like the simplicity of that. If we used a total, I'd want to size the default based on the number of CPUs, which this already does. -- To view, visit http://gerrit.cloudera.org:8080/24403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a84eacb66eb0a216bfb2159542a0d7e4ddf8ec2 Gerrit-Change-Number: 24403 Gerrit-PatchSet: 9 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 24 Jun 2026 07:43:51 +0000 Gerrit-HasComments: Yes
