Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg ...................................................................... Patch Set 3: (2 comments) Thanks for working on this. http://gerrit.cloudera.org:8080/#/c/24489/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24489/3//COMMIT_MSG@8 PS3, Line 8: Please write description for the commit. Also add a section about testing. Before that, please add/extend tests in test_iceberg.py that verify that the metadata is written correctly. http://gerrit.cloudera.org:8080/#/c/24489/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/24489/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1479 PS3, Line 1479: "4.4.0" Latest released version is 4.5.0. Anyway, please use BackendConfig.INSTANCE.getImpalaBuildVersion() instead of a hard-wired constant. -- To view, visit http://gerrit.cloudera.org:8080/24489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2 Gerrit-Change-Number: 24489 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 24 Jun 2026 12:48:57 +0000 Gerrit-HasComments: Yes
