Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24489 )
Change subject: IMPALA-14997: Set EnvironmentContext for Iceberg ...................................................................... Patch Set 5: (10 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24489/5/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/24489/5/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1906 PS5, Line 1906: envContext.putToProperties("engine.version", BackendConfig.INSTANCE.getImpalaBuildVersion()); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2853 PS5, Line 2853: d flake8: E301 expected 1 blank line, found 0 http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2857 PS5, Line 2857: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2857 PS5, Line 2857: CREATE TABLE {0}.{1} (id INT) line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2860 PS5, Line 2860: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2860 PS5, Line 2860: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2866 PS5, Line 2866: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2866 PS5, Line 2866: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2868 PS5, Line 2868: m flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/24489/5/tests/query_test/test_iceberg.py@2869 PS5, Line 2869: t flake8: E501 line too long (95 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/24489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida130d78217c47b6a9894b1e4cb014f4e65247b2 Gerrit-Change-Number: 24489 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 24 Jun 2026 14:40:58 +0000 Gerrit-HasComments: Yes
