Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24448 )
Change subject: IMPALA-14799: Add oauth_servers support and tests ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/24448/10/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/24448/10/be/src/rpc/authentication.cc@796 PS10, Line 796: bool JWTTokenAuth(ThriftServer::ConnectionContext* connection_context, Now that all JWT/OAuth configs (including legacy configs) are in one place in oauth_servers_mgr(), let's get rid of the duplicate JWTTokenAuth function and use only the OAuthTokenAuth function (since that function contains slightly different logic to add a response header). http://gerrit.cloudera.org:8080/#/c/24448/10/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/24448/10/be/src/util/webserver.cc@1158 PS10, Line 1158: bool Webserver::JWTTokenAuth(const std::string& jwt_token, Now that all JWT/OAuth configs (including legacy configs) are in one place in oauth_servers_mgr(), let's get rid of the duplicate Webserver::JWTTokenAuth function and use only the Webserver::OAuthTokenAuth function (since that function contains slightly different logic to add a response header). -- To view, visit http://gerrit.cloudera.org:8080/24448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib29ff36600406ba59c10f29d79cc632020f4a3f7 Gerrit-Change-Number: 24448 Gerrit-PatchSet: 10 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Wed, 24 Jun 2026 18:02:16 +0000 Gerrit-HasComments: Yes
