Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24446 )
Change subject: IMPALA-15093: Use RE2 For Profile Analyzer Regex ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/24446/3/be/src/service/query-profile-parsing-tools-test.cc File be/src/service/query-profile-parsing-tools-test.cc: http://gerrit.cloudera.org:8080/#/c/24446/3/be/src/service/query-profile-parsing-tools-test.cc@522 PS3, Line 522: TEST(QueryProfileParsingToolsTest, > Done Done http://gerrit.cloudera.org:8080/#/c/24446/3/be/src/service/query-profile-parsing-tools-test.cc@536 PS3, Line 536: > Done Done http://gerrit.cloudera.org:8080/#/c/24446/4/be/src/service/query-profile-parsing-tools-test.cc File be/src/service/query-profile-parsing-tools-test.cc: http://gerrit.cloudera.org:8080/#/c/24446/4/be/src/service/query-profile-parsing-tools-test.cc@524 PS4, Line 524: EXPECT_NEAR(3723004.0, test::ParseDurationMs("1h2m3s4ms"), 1e-9); : EXPECT_NEAR(3723001.34, test::ParseDurationMs("1h2m3s1.34ms"), 1e-9); : EXPECT_NEAR(120050.0, test::ParseDurationMs("2m0.05s"), 1e-9); ParseDurationMs should be deterministic which means that the assert function would be EXPECT_EQ instead of EXPECT_NEAR. http://gerrit.cloudera.org:8080/#/c/24446/3/be/src/service/query-profile-redaction-test.cc File be/src/service/query-profile-redaction-test.cc: http://gerrit.cloudera.org:8080/#/c/24446/3/be/src/service/query-profile-redaction-test.cc@323 PS3, Line 323: TEST(QueryProfileRedactionTest, > Done Done -- To view, visit http://gerrit.cloudera.org:8080/24446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1343b2f049758e862d229f2a647273de56855c4 Gerrit-Change-Number: 24446 Gerrit-PatchSet: 4 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 24 Jun 2026 18:52:15 +0000 Gerrit-HasComments: Yes
