Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24446 )
Change subject: IMPALA-15093: Use RE2 For Profile Analyzer Regex ...................................................................... Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/24446/3/be/src/service/query-profile-parsing-tools-test.cc File be/src/service/query-profile-parsing-tools-test.cc: http://gerrit.cloudera.org:8080/#/c/24446/3/be/src/service/query-profile-parsing-tools-test.cc@522 PS3, Line 522: TEST(QueryProfileParsingToolsTest, CTest tests should function more like unit tests if possible where they exercise the smallest unit of code possible. Please consider adding a namespace test to query-profile-parsing-tools.h (same as in https://github.com/apache/impala/blob/0b8294b1a5b0ad4a817dee13b7fbb2ee53f534e2/be/src/service/query-profile-ai-analysis.h#L48) that exposes the ParseDurationMs() function and directly calls it. http://gerrit.cloudera.org:8080/#/c/24446/3/be/src/service/query-profile-parsing-tools-test.cc@536 PS3, Line 536: "value": "1:SCAN NODE 3 4 1h2m3s4ms 2h4m6s8ms" Since the DURATION_COMPONENT_RE supports optional decimal values, please add a second value with a decimal duration in it (e.g 1.34ms). http://gerrit.cloudera.org:8080/#/c/24446/1/be/src/service/query-profile-parsing-tools.cc File be/src/service/query-profile-parsing-tools.cc: http://gerrit.cloudera.org:8080/#/c/24446/1/be/src/service/query-profile-parsing-tools.cc@775 PS1, Line 775: re2::StringPiece plan(plan_value.GetString(), plan_value.GetStringLength()); > Done Done http://gerrit.cloudera.org:8080/#/c/24446/1/be/src/service/query-profile-parsing-tools.cc@790 PS1, Line 790: string estimates_match; > Done Done http://gerrit.cloudera.org:8080/#/c/24446/1/be/src/service/query-profile-parsing-tools.cc@1125 PS1, Line 1125: double total_ms = 0.0; > Done Done http://gerrit.cloudera.org:8080/#/c/24446/1/be/src/service/query-profile-parsing-tools.cc@1134 PS1, Line 1134: total_ms += amount * 3600000.0; > Done Done http://gerrit.cloudera.org:8080/#/c/24446/3/be/src/service/query-profile-redaction-test.cc File be/src/service/query-profile-redaction-test.cc: http://gerrit.cloudera.org:8080/#/c/24446/3/be/src/service/query-profile-redaction-test.cc@323 PS3, Line 323: TEST(QueryProfileRedactionTest, CTest tests should function more like unit tests if possible where they exercise the smallest unit of code possible. Please consider adding a namespace test to query-profile-parsing-tools.h (same as in https://github.com/apache/impala/blob/0b8294b1a5b0ad4a817dee13b7fbb2ee53f534e2/be/src/service/query-profile-ai-analysis.h#L48) that exposes the CollectRegexMatches() function and directly calls it. http://gerrit.cloudera.org:8080/#/c/24446/1/be/src/service/query-profile-redaction.cc File be/src/service/query-profile-redaction.cc: http://gerrit.cloudera.org:8080/#/c/24446/1/be/src/service/query-profile-redaction.cc@99 PS1, Line 99: // Collects unique regex matches from text using the first capture group. > Done Done -- To view, visit http://gerrit.cloudera.org:8080/24446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1343b2f049758e862d229f2a647273de56855c4 Gerrit-Change-Number: 24446 Gerrit-PatchSet: 3 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 17 Jun 2026 19:00:09 +0000 Gerrit-HasComments: Yes
