Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24502 )
Change subject: IMPALA-15107: Support Direct Thrift Upload for AI Profile Analyzer ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/24502/1/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/24502/1/be/src/service/impala-http-handler.cc@100 PS1, Line 100: string thrift_profile_archive This will create a copy of the entire Thrift profile. Change the parameter type to string_view instead. http://gerrit.cloudera.org:8080/#/c/24502/1/be/src/service/impala-http-handler.cc@497 PS1, Line 497: return set_error("No 'query_id' argument found. CLI thrift profile upload must " : "use POST."); This error should return a 405 Method Not Allowed -- https://www.rfc-editor.org/info/rfc9110/#status.405 http://gerrit.cloudera.org:8080/#/c/24502/1/be/src/service/impala-http-handler.cc@501 PS1, Line 501: string thrift_profile_archive; This will create a copy of the string data. Use string_view instead. http://gerrit.cloudera.org:8080/#/c/24502/1/be/src/service/impala-http-handler.cc@511 PS1, Line 511: Substitute("Could not parse uploaded thrift profile: $0", status.GetDetail())); Does this error return a 400 Bad Request -- https://httpwg.org/specs/rfc9110.html#status.400? http://gerrit.cloudera.org:8080/#/c/24502/1/be/src/service/query-profile-ai-analysis.cc File be/src/service/query-profile-ai-analysis.cc: http://gerrit.cloudera.org:8080/#/c/24502/1/be/src/service/query-profile-ai-analysis.cc@924 PS1, Line 924: string(thrift_profile_archive) This creates an unnecessary copy of the data. Pass the string_view by value instead. -- To view, visit http://gerrit.cloudera.org:8080/24502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff05c3cde7b34a56e31f020611cc33ff4e02aa32 Gerrit-Change-Number: 24502 Gerrit-PatchSet: 1 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 24 Jun 2026 21:24:16 +0000 Gerrit-HasComments: Yes
