Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24502 )
Change subject: IMPALA-15107: Support Direct Thrift Upload for AI Profile Analyzer ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/24502/1/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/24502/1/be/src/service/impala-http-handler.cc@100 PS1, Line 100: ile (!input.empty() && isspac > This will create a copy of the entire Thrift profile. Change the parameter Done http://gerrit.cloudera.org:8080/#/c/24502/1/be/src/service/impala-http-handler.cc@497 PS1, Line 497: DCHECK(data != nullptr); : DCHECK(response != nullptr); > This error should return a 405 Method Not Allowed -- https://www.rfc-editor Done http://gerrit.cloudera.org:8080/#/c/24502/1/be/src/service/impala-http-handler.cc@501 PS1, Line 501: auto set_error = [&](const string& error_msg, > This will create a copy of the string data. Use string_view instead. Done http://gerrit.cloudera.org:8080/#/c/24502/1/be/src/service/impala-http-handler.cc@511 PS1, Line 511: Status status; > Does this error return a 400 Bad Request -- https://httpwg.org/specs/rfc911 It does now http://gerrit.cloudera.org:8080/#/c/24502/1/be/src/service/query-profile-ai-analysis.cc File be/src/service/query-profile-ai-analysis.cc: http://gerrit.cloudera.org:8080/#/c/24502/1/be/src/service/query-profile-ai-analysis.cc@924 PS1, Line 924: thrift_profile_archive, &profi > This creates an unnecessary copy of the data. Pass the string_view by valu Done -- To view, visit http://gerrit.cloudera.org:8080/24502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff05c3cde7b34a56e31f020611cc33ff4e02aa32 Gerrit-Change-Number: 24502 Gerrit-PatchSet: 2 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 24 Jun 2026 22:29:59 +0000 Gerrit-HasComments: Yes
