Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24509 )
Change subject: IMPALA-13794: More Accurate Iceberg Metadata Memory Estimates ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/24509/2/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/24509/2/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@652 PS2, Line 652: 494 The numbers look a bit ad hoc to me, for example why are data files without deletes bigger than data files with deletes? Also, this numbers are pretty close to PER_FD_MEM_USAGE_BYTES=500, so I would rather use that constant for the first 4 lists. Btw I don't understand why they need 500 bytes if block locations are not considered. Are you sure that block locations were ignored in you measurement? http://gerrit.cloudera.org:8080/#/c/24509/2/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@653 PS2, Line 653: fileStore_ As this mainly uses members from IcebergContentFileStore, that class could get a member functions for memory estimates. http://gerrit.cloudera.org:8080/#/c/24509/2/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@657 PS2, Line 657: 163 HdfsTable uses much higher estimate: PER_PARTITION_MEM_USAGE_BYTES = 2048 It is true that in HdfsTable we store more metadata for partitions, but the diff still looks a bit large. -- To view, visit http://gerrit.cloudera.org:8080/24509 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I471e6460ac0f2f924c0a701a077bfc22def8aa7b Gerrit-Change-Number: 24509 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 25 Jun 2026 08:36:17 +0000 Gerrit-HasComments: Yes
