Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24509 )

Change subject: IMPALA-13794: More Accurate Iceberg Metadata Memory Estimates
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24509/2/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java:

http://gerrit.cloudera.org:8080/#/c/24509/2/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@652
PS2, Line 652: 494
> perhaps I should have measured the size of the EncodedFileDescriptor object

actually measuring that is also wrong, because it ignore the overhead of the 
hash table and the key

I would measure the whole members (like dataFilesWithoutDeletes_), and divide 
it with the number of files.



--
To view, visit http://gerrit.cloudera.org:8080/24509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I471e6460ac0f2f924c0a701a077bfc22def8aa7b
Gerrit-Change-Number: 24509
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Fri, 26 Jun 2026 12:21:19 +0000
Gerrit-HasComments: Yes

Reply via email to