Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24429 )
Change subject: IMPALA-15090: Make Query Profile Redaction DOM to DOM ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/24429/5/be/src/service/query-profile-redaction.cc File be/src/service/query-profile-redaction.cc: http://gerrit.cloudera.org:8080/#/c/24429/5/be/src/service/query-profile-redaction.cc@404 PS5, Line 404: if (value.IsDouble()) return std::to_string(value.GetDouble()).size(); > This does not match the serialization that the size limit is meant to bound Thanks, this looks fixed in PS7. http://gerrit.cloudera.org:8080/#/c/24429/5/be/src/service/query-profile-redaction.cc@561 PS5, Line 561: json_value->SetString( > This looks like it can keep a second copy of almost every string/key in the Thanks, this looks fixed in PS7. -- To view, visit http://gerrit.cloudera.org:8080/24429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b8ad721a5531e9d257cf6e54b83ea3ee9734039 Gerrit-Change-Number: 24429 Gerrit-PatchSet: 5 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 25 Jun 2026 11:20:33 +0000 Gerrit-HasComments: Yes
