Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24429 )
Change subject: IMPALA-15090: Make Query Profile Redaction DOM to DOM ...................................................................... Patch Set 7: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24429/7/be/src/service/query-profile-redaction-test.cc File be/src/service/query-profile-redaction-test.cc: http://gerrit.cloudera.org:8080/#/c/24429/7/be/src/service/query-profile-redaction-test.cc@292 PS7, Line 292: const string redacted_summary = : "sql=[REDACTED_SQL_STATEMENT] user=user_001 ip=ip_001 " : "host=host_001 table=table_001 column=column_001"; : const string unredacted_summary = redactor.Unredact(redacted_summary); : EXPECT_EQ(string::npos, unredacted_summary.find("[REDACTED_SQL_STATEMENT]")); : EXPECT_EQ(string::npos, unredacted_summary.find("user_001")); : EXPECT_EQ(string::npos, unredacted_summary.find("ip_001")); : EXPECT_EQ(string::npos, unredacted_summary.find("host_001")); : EXPECT_EQ(string::npos, unredacted_summary.find("table_001")); : EXPECT_EQ(string::npos, unredacted_summary.find("column_001")); It is better to also ensure the original values were actually restored. EXPECT_STR_CONTAINS(unredacted_summary, "select raw_value from pii_db.customer_table"); EXPECT_STR_CONTAINS(unredacted_summary, "primary_user"); EXPECT_STR_CONTAINS(unredacted_summary, "10.20.30.40"); EXPECT_STR_CONTAINS(unredacted_summary, "worker-a.example.com"); EXPECT_STR_CONTAINS(unredacted_summary, "sales_db.order_table"); EXPECT_STR_CONTAINS(unredacted_summary, "customer_id"); http://gerrit.cloudera.org:8080/#/c/24429/7/be/src/service/query-profile-redaction-test.cc@374 PS7, Line 374: 161 Is the purpose compared to JsonToString(profile_json).size()? Maybe directly use JsonToString(profile_json).size()? -- To view, visit http://gerrit.cloudera.org:8080/24429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b8ad721a5531e9d257cf6e54b83ea3ee9734039 Gerrit-Change-Number: 24429 Gerrit-PatchSet: 7 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 17 Aug 2026 05:28:04 +0000 Gerrit-HasComments: Yes
