Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24512 )
Change subject: POC/slop: decreae per file memory usage in catalog ...................................................................... Patch Set 1: (8 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24512/1/common/fbs/CatalogObjects.fbs File common/fbs/CatalogObjects.fbs: PS1: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new fields can be added and should be added at the end of a table definition. https://flatbuffers.dev/flatbuffers_guide_writing_schema.html http://gerrit.cloudera.org:8080/#/c/24512/1/fe/src/main/java/org/apache/impala/catalog/FileBlock.java File fe/src/main/java/org/apache/impala/catalog/FileBlock.java: http://gerrit.cloudera.org:8080/#/c/24512/1/fe/src/main/java/org/apache/impala/catalog/FileBlock.java@181 PS1, Line 181: (i == 1) ? (short) sbd.replicaHostIdx1() : (short) sbd.replicaHostIdx2(); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24512/1/fe/src/main/java/org/apache/impala/catalog/FileDescriptor.java File fe/src/main/java/org/apache/impala/catalog/FileDescriptor.java: http://gerrit.cloudera.org:8080/#/c/24512/1/fe/src/main/java/org/apache/impala/catalog/FileDescriptor.java@300 PS1, Line 300: if ((fbFileDescriptor_.flags() & FbFileDescFlags.IS_PATH_ABSOLUTE) != 0) return StringUtils.EMPTY; line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/24512/1/fe/src/main/java/org/apache/impala/catalog/FileDescriptor.java@306 PS1, Line 306: if ((fbFileDescriptor_.flags() & FbFileDescFlags.IS_PATH_ABSOLUTE) != 0) return fbFileDescriptor_.path(); line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/24512/1/fe/src/main/java/org/apache/impala/catalog/FileDescriptor.java@311 PS1, Line 311: if ((fbFileDescriptor_.flags() & FbFileDescFlags.IS_PATH_ABSOLUTE) != 0) return fbFileDescriptor_.path(); line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/24512/1/fe/src/main/java/org/apache/impala/catalog/IcebergFileDescriptor.java File fe/src/main/java/org/apache/impala/catalog/IcebergFileDescriptor.java: http://gerrit.cloudera.org:8080/#/c/24512/1/fe/src/main/java/org/apache/impala/catalog/IcebergFileDescriptor.java@42 PS1, Line 42: public IcebergFileDescriptor(FbFileDesc fileDescData, FbIcebergMetadata icebergMetadata) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24512/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/24512/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@76 PS1, Line 76: import org.apache.impala.fb.FbFileBlock; unused import: org.apache.impala.fb.FbFileBlock http://gerrit.cloudera.org:8080/#/c/24512/1/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java File fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java: http://gerrit.cloudera.org:8080/#/c/24512/1/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java@42 PS1, Line 42: import org.apache.impala.fb.FbFileBlock; unused import: org.apache.impala.fb.FbFileBlock -- To view, visit http://gerrit.cloudera.org:8080/24512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id48c7785ec88e16a9b79ac910add2c0a240869e3 Gerrit-Change-Number: 24512 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 25 Jun 2026 13:56:33 +0000 Gerrit-HasComments: Yes
