Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24512 )
Change subject: POC/slop: decrease per file memory usage in catalog ...................................................................... Patch Set 2: (4 comments) Direction seems fine. I think there is some inaccuracy in comments that could be cleaned up. http://gerrit.cloudera.org:8080/#/c/24512/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24512/1//COMMIT_MSG@22 PS1, Line 22: - rearranged members to avoid padding (~8 byte?) Was there actually any rearranging? http://gerrit.cloudera.org:8080/#/c/24512/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24512/2//COMMIT_MSG@26 PS2, Line 26: - reordered FbIcebergMetadata to avoid padding (~8 byte) I don't see any changes like this. http://gerrit.cloudera.org:8080/#/c/24512/1/be/src/scheduling/scheduler-test-util.cc File be/src/scheduling/scheduler-test-util.cc: http://gerrit.cloudera.org:8080/#/c/24512/1/be/src/scheduling/scheduler-test-util.cc@420 PS1, Line 420: FbFileDescBuilder fb_file_desc_builder(fb_builder); Why'd this change? http://gerrit.cloudera.org:8080/#/c/24512/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/24512/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@1300 PS2, Line 1300: // This matches the order in the generated createFbIcebergMetadata() and saves I'm not sure what createFbIcebergMetadata is referring to. -- To view, visit http://gerrit.cloudera.org:8080/24512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id48c7785ec88e16a9b79ac910add2c0a240869e3 Gerrit-Change-Number: 24512 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 25 Jun 2026 16:40:06 +0000 Gerrit-HasComments: Yes
