Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24271 )
Change subject: IMPALA-14904: Calcite planner: Enable width_bucket function ...................................................................... Patch Set 4: (17 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@45 PS4, Line 45: import org.apache.impala.catalog.TypeCompatibility; unused import: org.apache.impala.catalog.TypeCompatibility http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java: http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@46 PS4, Line 46: import org.apache.impala.catalog.TypeCompatibility; unused import: org.apache.impala.catalog.TypeCompatibility http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/CommonOperatorFunctions.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/CommonOperatorFunctions.java: http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/CommonOperatorFunctions.java@20 PS4, Line 20: import org.apache.impala.calcite.type.ImpalaTypeSystemImpl; unused import: org.apache.impala.calcite.type.ImpalaTypeSystemImpl http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/CommonOperatorFunctions.java@34 PS4, Line 34: import org.apache.impala.catalog.TypeCompatibility; unused import: org.apache.impala.catalog.TypeCompatibility http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCastFunction.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCastFunction.java: http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCastFunction.java@23 PS4, Line 23: import org.apache.impala.calcite.type.ImpalaTypeSystemImpl; unused import: org.apache.impala.calcite.type.ImpalaTypeSystemImpl http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCoalesceFunction.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCoalesceFunction.java: http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCoalesceFunction.java@25 PS4, Line 25: import org.apache.impala.calcite.type.ImpalaTypeSystemImpl; unused import: org.apache.impala.calcite.type.ImpalaTypeSystemImpl http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCoalesceFunction.java@26 PS4, Line 26: import org.apache.impala.catalog.TypeCompatibility; unused import: org.apache.impala.catalog.TypeCompatibility http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaDecodeFunction.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaDecodeFunction.java: http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaDecodeFunction.java@28 PS4, Line 28: import org.apache.impala.calcite.type.ImpalaTypeSystemImpl; unused import: org.apache.impala.calcite.type.ImpalaTypeSystemImpl http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaDecodeFunction.java@29 PS4, Line 29: import org.apache.impala.catalog.TypeCompatibility; unused import: org.apache.impala.catalog.TypeCompatibility http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java: http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java@46 PS4, Line 46: import org.apache.impala.calcite.type.ImpalaTypeSystemImpl; unused import: org.apache.impala.calcite.type.ImpalaTypeSystemImpl http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java: http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@22 PS4, Line 22: import org.apache.calcite.jdbc.JavaTypeFactoryImpl; unused import: org.apache.calcite.jdbc.JavaTypeFactoryImpl http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@43 PS4, Line 43: import org.apache.impala.calcite.type.ImpalaTypeSystemImpl; unused import: org.apache.impala.calcite.type.ImpalaTypeSystemImpl http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@52 PS4, Line 52: import org.apache.impala.common.ParseException; unused import: org.apache.impala.common.ParseException http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java: http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@43 PS4, Line 43: import org.apache.impala.calcite.type.ImpalaTypeSystemImpl; unused import: org.apache.impala.calcite.type.ImpalaTypeSystemImpl http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeCoercionImpl.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeCoercionImpl.java: http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeCoercionImpl.java@35 PS4, Line 35: import org.apache.impala.catalog.ScalarType; unused import: org.apache.impala.catalog.ScalarType http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeCoercionImpl.java@37 PS4, Line 37: import org.apache.impala.catalog.TypeCompatibility; unused import: org.apache.impala.catalog.TypeCompatibility http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeFactoryImpl.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeFactoryImpl.java: http://gerrit.cloudera.org:8080/#/c/24271/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeFactoryImpl.java@25 PS4, Line 25: import org.apache.impala.catalog.TypeCompatibility; unused import: org.apache.impala.catalog.TypeCompatibility -- To view, visit http://gerrit.cloudera.org:8080/24271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2944fde1301e48b3fb0c29be7290b1ad9533e5b6 Gerrit-Change-Number: 24271 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 25 Jun 2026 17:35:25 +0000 Gerrit-HasComments: Yes
