Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24208 )
Change subject: IMPALA-14903: Calcite planner: Simplify code for string literals ...................................................................... Patch Set 13: (11 comments) http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@30 PS12, Line 30: import org.apache.calcite.rel.type.RelDataType; > unused import: org.apache.calcite.rel.logical.LogicalValues Done http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@39 PS12, Line 39: import org.apache.calcite.util.Util; > unused import: org.apache.calcite.sql.SqlKind Done http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@49 PS12, Line 49: import java.util.stream.Collectors; > unused import: java.util.Arrays Done http://gerrit.cloudera.org:8080/#/c/24208/13/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java: http://gerrit.cloudera.org:8080/#/c/24208/13/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@116 PS13, Line 116: ) > nit: we usually put the right parenthesis above Done http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ParentPlanRelContext.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ParentPlanRelContext.java: http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ParentPlanRelContext.java@20 PS12, Line 20: import org.apache.calcite.rex.RexNode; > unused import: org.apache.calcite.rel.type.RelDataType Done http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java: http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@25 PS12, Line 25: import org.apache.calcite.sql.validate.SelectScope; > unused import: org.apache.calcite.sql.type.SqlTypeName Done http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@37 PS12, Line 37: import org.apache.calcite.sql.SqlCall; > unused import: org.apache.calcite.sql.validate.SqlValidatorUtil Done http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@60 PS12, Line 60: /** > unused import: java.util.ArrayList Done http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@61 PS12, Line 61: * The ImpalaSqlValidatorImpl is responsible for registering column-level and > unused import: java.util.HashSet Done http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@62 PS12, Line 62: * function-level privilege requests in the given query. The methods in the class will be > unused import: java.util.List Done http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@64 PS12, Line 64: */ > unused import: java.util.Set Done -- To view, visit http://gerrit.cloudera.org:8080/24208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8e61b2555afd81ef52f19431fdd1224d4039c00 Gerrit-Change-Number: 24208 Gerrit-PatchSet: 13 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 26 Jun 2026 02:22:09 +0000 Gerrit-HasComments: Yes
