Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24208 )
Change subject: IMPALA-14903: Calcite planner: Simplify code for string literals ...................................................................... Patch Set 12: (10 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@30 PS12, Line 30: import org.apache.calcite.rel.logical.LogicalValues; unused import: org.apache.calcite.rel.logical.LogicalValues http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@39 PS12, Line 39: import org.apache.calcite.sql.SqlKind; unused import: org.apache.calcite.sql.SqlKind http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@49 PS12, Line 49: import java.util.Arrays; unused import: java.util.Arrays http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ParentPlanRelContext.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ParentPlanRelContext.java: http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ParentPlanRelContext.java@20 PS12, Line 20: import org.apache.calcite.rel.type.RelDataType; unused import: org.apache.calcite.rel.type.RelDataType http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java: http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@25 PS12, Line 25: import org.apache.calcite.sql.type.SqlTypeName; unused import: org.apache.calcite.sql.type.SqlTypeName http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@37 PS12, Line 37: import org.apache.calcite.sql.validate.SqlValidatorUtil; unused import: org.apache.calcite.sql.validate.SqlValidatorUtil http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@60 PS12, Line 60: import java.util.ArrayList; unused import: java.util.ArrayList http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@61 PS12, Line 61: import java.util.HashSet; unused import: java.util.HashSet http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@62 PS12, Line 62: import java.util.List; unused import: java.util.List http://gerrit.cloudera.org:8080/#/c/24208/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@64 PS12, Line 64: import java.util.Set; unused import: java.util.Set -- To view, visit http://gerrit.cloudera.org:8080/24208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8e61b2555afd81ef52f19431fdd1224d4039c00 Gerrit-Change-Number: 24208 Gerrit-PatchSet: 12 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 25 Jun 2026 14:45:33 +0000 Gerrit-HasComments: Yes
