Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24311 )
Change subject: IMPALA-14999: Calcite planner: support Iceberg tables (part 2) ...................................................................... Patch Set 15: Code-Review+1 (7 comments) Found a few nits, otherwise LGTM! http://gerrit.cloudera.org:8080/#/c/24311/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java: http://gerrit.cloudera.org:8080/#/c/24311/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java@237 PS15, Line 237: Preconditions.checkNotNull nit: the above Enum.valueOf() doesn't return NULL, it throws either IllegalArgumentException or NullPointerException. http://gerrit.cloudera.org:8080/#/c/24311/13/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-default.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-default.test: http://gerrit.cloudera.org:8080/#/c/24311/13/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-default.test@312 PS13, Line 312: # IMPALA-XXXXX: Iceberg should recognized this as a pattern that can be used for count start > nit: it should be a real ticket id, same goes for other test files This is still unresolved. http://gerrit.cloudera.org:8080/#/c/24311/15/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-v1.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-v1.test: http://gerrit.cloudera.org:8080/#/c/24311/15/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-v1.test@303 PS15, Line 303: IMPALA-XXXXX Placeholder ticket http://gerrit.cloudera.org:8080/#/c/24311/15/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-v1.test@316 PS15, Line 316: IMPALA-XXXXX Placeholder ticket http://gerrit.cloudera.org:8080/#/c/24311/15/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-v2.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-v2.test: http://gerrit.cloudera.org:8080/#/c/24311/15/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-v2.test@303 PS15, Line 303: IMPALA-XXXXX Placeholder ticket http://gerrit.cloudera.org:8080/#/c/24311/15/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-v2.test@316 PS15, Line 316: IMPALA-XXXXX Placeholder ticket http://gerrit.cloudera.org:8080/#/c/24311/15/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-plain-count-star-optimization.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-plain-count-star-optimization.test: http://gerrit.cloudera.org:8080/#/c/24311/15/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-plain-count-star-optimization.test@42 PS15, Line 42: BIGINT Should be BIGINT,BIGINT -- To view, visit http://gerrit.cloudera.org:8080/24311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1854012b1caac63ced292b338d40074db950b42d Gerrit-Change-Number: 24311 Gerrit-PatchSet: 15 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 26 Jun 2026 15:35:29 +0000 Gerrit-HasComments: Yes
