Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24530 )
Change subject: IMPALA-15130: Reject column masking on complex-typed columns ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/24530/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24530/1//COMMIT_MSG@16 PS1, Line 16: hasComplexColumnMask_ ouch, it disappeared between ps 22 and 23 for some reason in https://gerrit.cloudera.org/#/c/17811/ http://gerrit.cloudera.org:8080/#/c/24530/1//COMMIT_MSG@33 PS1, Line 33: unmasasked typo http://gerrit.cloudera.org:8080/#/c/24530/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/24530/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@3384 PS1, Line 3384: setExpand_complex_types Why is this needed? I don't see select * in the test http://gerrit.cloudera.org:8080/#/c/24530/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@3392 PS1, Line 3392: int_array structs could be also checked http://gerrit.cloudera.org:8080/#/c/24530/1/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_struct_in_select_list.test File testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_struct_in_select_list.test: http://gerrit.cloudera.org:8080/#/c/24530/1/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_struct_in_select_list.test@a35 PS1, Line 35: Why not keep adding the mask and check that the query returns an error here? There are many related tests in this file, I think that it is useful for show here how masks on complex types are handled. -- To view, visit http://gerrit.cloudera.org:8080/24530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idddacf0b40abcaa18a5764ff617179fe898886c9 Gerrit-Change-Number: 24530 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 01 Jul 2026 15:36:18 +0000 Gerrit-HasComments: Yes
