Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24530 )

Change subject: IMPALA-15130: Reject column masking on complex-typed columns
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/24530/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24530/1//COMMIT_MSG@33
PS1, Line 33:  This show
> typo
Done


http://gerrit.cloudera.org:8080/#/c/24530/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
File 
fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java:

http://gerrit.cloudera.org:8080/#/c/24530/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@3384
PS1, Line 3384: "complextypestbl_nested
> Why is this needed? I don't see select * in the test
Done


http://gerrit.cloudera.org:8080/#/c/24530/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@3392
PS1, Line 3392: tComplexC
> structs could be also checked
Done, also MAP.


http://gerrit.cloudera.org:8080/#/c/24530/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@3411
PS1, Line 3411:     }
> line too long (91 > 90)
Done



--
To view, visit http://gerrit.cloudera.org:8080/24530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idddacf0b40abcaa18a5764ff617179fe898886c9
Gerrit-Change-Number: 24530
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Thu, 02 Jul 2026 13:02:05 +0000
Gerrit-HasComments: Yes

Reply via email to