Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24531 )
Change subject: IMPALA-15131: Simplify file format handling in hdfs-scan-node ...................................................................... Patch Set 3: Code-Review+2 (2 comments) Nice simplification! http://gerrit.cloudera.org:8080/#/c/24531/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24531/3//COMMIT_MSG@14 PS3, Line 14: Change-Id: I82f84d17e67cb0bb6dbba2ea86b602290d96de8c Offline you mentioned you discussed the idea with Claude. Do you want to add 'Assisted-by'? http://gerrit.cloudera.org:8080/#/c/24531/3/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: http://gerrit.cloudera.org:8080/#/c/24531/3/be/src/exec/hdfs-scan-node-base.cc@914 PS3, Line 914: const HdfsFileDesc* file_desc = context->GetStream(0)->file_desc(); Optional: add validation check for Iceberg tables that the format is in [PARQUET, ORC, AVRO]. -- To view, visit http://gerrit.cloudera.org:8080/24531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82f84d17e67cb0bb6dbba2ea86b602290d96de8c Gerrit-Change-Number: 24531 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 02 Jul 2026 07:44:01 +0000 Gerrit-HasComments: Yes
