Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24531 )

Change subject: IMPALA-15131: Simplify file format handling in hdfs-scan-node
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24531/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24531/3//COMMIT_MSG@14
PS3, Line 14: Assisted-by: Claude Opus 4.8
> Offline you mentioned you discussed the idea with Claude. Do you want to ad
Done


http://gerrit.cloudera.org:8080/#/c/24531/3/be/src/exec/hdfs-scan-node-base.cc
File be/src/exec/hdfs-scan-node-base.cc:

http://gerrit.cloudera.org:8080/#/c/24531/3/be/src/exec/hdfs-scan-node-base.cc@914
PS3, Line 914:   const HdfsFileDesc* file_desc = 
context->GetStream(0)->file_desc();
> Optional: add validation check for Iceberg tables that the format is in [PA
I would prefer not to, I like that now this function doesn't have to know about 
Iceberg.



--
To view, visit http://gerrit.cloudera.org:8080/24531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82f84d17e67cb0bb6dbba2ea86b602290d96de8c
Gerrit-Change-Number: 24531
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Thu, 02 Jul 2026 11:18:08 +0000
Gerrit-HasComments: Yes

Reply via email to