Steve Carlin has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/24218 )
Change subject: IMPALA-14912: Calcite Planner: Fix date string parsing ...................................................................... IMPALA-14912: Calcite Planner: Fix date string parsing This commit fixes parsing for the following date strings SQL select DATE '1999-01-01'; select DATE "1999-01-01"; This essentially reverts an earlier fix, IMPALA-13525, which was way more complicated than it needed to be. The Impala StringLiteral already handles escaped strings, so there is no need to remove the escapes within the Calcite parser. The changes in Parser.jj reflect the major part of the reversion, as well as removing the ParserUtil.java file. A change also had to be made in the ImpalaRexExecutor where the constant folding was done. This completes the UTF-8 constant folding commit for the Calcite Planner (IMPALA-10349) One more change was made with the unhex function. Unhex can return a non-UTF8 string. Impala can handle this in a StringLiteral, but Calcite cannot. Because of this, the constant folding for unhex when the string is non-UTF8 is done at physical node creation time rather than during the optimization phase. Change-Id: Ia08071193f86423a0e548c6b6690993afdad6272 --- M fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java M java/calcite-planner/src/main/codegen/templates/Parser.jj M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexLiteralConverter.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaValuesRel.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaRexExecutor.java D java/calcite-planner/src/main/java/org/apache/impala/calcite/util/ParserUtil.java 7 files changed, 52 insertions(+), 225 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/24218/5 -- To view, visit http://gerrit.cloudera.org:8080/24218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia08071193f86423a0e548c6b6690993afdad6272 Gerrit-Change-Number: 24218 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]>
