Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24218 )
Change subject: IMPALA-14912: Calcite Planner: Fix date string parsing ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/24218/7/fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java File fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java: http://gerrit.cloudera.org:8080/#/c/24218/7/fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java@61 PS7, Line 61: public static LiteralExpr createFromUnescapedStr(String value, Type type) nit: could use a javadoc. http://gerrit.cloudera.org:8080/#/c/24218/7/fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java@64 PS7, Line 64: } nit: add newline after this http://gerrit.cloudera.org:8080/#/c/24218/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java: http://gerrit.cloudera.org:8080/#/c/24218/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java@113 PS7, Line 113: if (rexCall.getOperator().getName().toLowerCase().equals("unhex") && I'm not clear why we have this and the check at line 143, which has equivalent logic in createUnhexExpr. http://gerrit.cloudera.org:8080/#/c/24218/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java@219 PS7, Line 219: return new StringLiteral(hex.parseHex(s), Type.STRING); Any chance this could throw IllegalArgumentException? http://gerrit.cloudera.org:8080/#/c/24218/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexLiteralConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexLiteralConverter.java: http://gerrit.cloudera.org:8080/#/c/24218/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexLiteralConverter.java@128 PS7, Line 128: StringLiteral stringLiteral = new StringLiteral(timestamp, Type.STRING, true); Why does this need unescaping? -- To view, visit http://gerrit.cloudera.org:8080/24218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia08071193f86423a0e548c6b6690993afdad6272 Gerrit-Change-Number: 24218 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2026 22:16:50 +0000 Gerrit-HasComments: Yes
