Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24405 )
Change subject: IMPALA-14783: Add time travel support for SHOW FILES on Iceberg tables ...................................................................... Patch Set 1: (4 comments) Thanks for working on this! Looks good overall! http://gerrit.cloudera.org:8080/#/c/24405/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24405/1//COMMIT_MSG@15 PS1, Line 15: [FOR SYSTEM_VERSION AS OF <integer_literal>] : [FOR SYSTEM_TIME AS OF <timestamp_expr>] nit: this means users could specify both SYSTEM_VERSION and SYSTEM_TIME. So it probably should be: [FOR SYSTEM_VERSION AS OF <integer_literal> | FOR SYSTEM_TIME AS OF <timestamp_expr>] http://gerrit.cloudera.org:8080/#/c/24405/1/fe/src/main/java/org/apache/impala/analysis/ShowFilesStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowFilesStmt.java: http://gerrit.cloudera.org:8080/#/c/24405/1/fe/src/main/java/org/apache/impala/analysis/ShowFilesStmt.java@52 PS1, Line 52: SHOW FILES IN [dbName.]tableName [PARTITION(key=value,...)] Please update syntax. http://gerrit.cloudera.org:8080/#/c/24405/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-time-travel.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-time-travel.test: http://gerrit.cloudera.org:8080/#/c/24405/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-time-travel.test@111 PS1, Line 111: ==== Can we have SHOW FILES for empty partition? http://gerrit.cloudera.org:8080/#/c/24405/1/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/24405/1/tests/query_test/test_iceberg.py@1638 PS1, Line 1638: Please add tests for tables where files are removed, e.g. due to compaction. Also: truncate table, then insert data, then issue SHOW FILES for the empty snapshot. -- To view, visit http://gerrit.cloudera.org:8080/24405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09215c4527cdc585af5340d5bb573d9da877a0c9 Gerrit-Change-Number: 24405 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 03 Jul 2026 17:16:31 +0000 Gerrit-HasComments: Yes
