Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24405 )
Change subject: IMPALA-14783: Add time travel support for SHOW FILES on Iceberg tables ...................................................................... Patch Set 4: (5 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24405/3/fe/src/main/java/org/apache/impala/analysis/ShowFilesStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowFilesStmt.java: http://gerrit.cloudera.org:8080/#/c/24405/3/fe/src/main/java/org/apache/impala/analysis/ShowFilesStmt.java@74 PS3, Line 74: TimeTravelSpec timeTravelSpec) { > Is this overload remain used elsewhere? Done. removed this as its not used anywhere else. http://gerrit.cloudera.org:8080/#/c/24405/3/fe/src/main/java/org/apache/impala/analysis/ShowFilesStmt.java@88 PS3, Line 88: > nit: could use the same formatting as partitionSet: Done http://gerrit.cloudera.org:8080/#/c/24405/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-time-travel.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-time-travel.test: http://gerrit.cloudera.org:8080/#/c/24405/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-time-travel.test@56 PS3, Line 56: ---- QUERY > I think this is already covered in existing tests Done. Removed the test cases. http://gerrit.cloudera.org:8080/#/c/24405/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-time-travel.test@95 PS3, Line 95: # Verify SELECT with timestamp > nit: I think it's enough to cover analyzer error cases only in the frontend Done http://gerrit.cloudera.org:8080/#/c/24405/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-time-travel.test@128 PS3, Line 128: SHOW FILES IN iceberg_truncate_showfiles FOR SYSTEM_VERSION AS OF $PRE_TRUNCATE_SNAPSHOT; > nit: same as L95 Done -- To view, visit http://gerrit.cloudera.org:8080/24405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09215c4527cdc585af5340d5bb573d9da877a0c9 Gerrit-Change-Number: 24405 Gerrit-PatchSet: 4 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 08 Jul 2026 06:07:41 +0000 Gerrit-HasComments: Yes
