Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24426 )
Change subject: IMPALA-14601: Support HBO for JoinNode cardinality ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/24426/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24426/5//COMMIT_MSG@54 PS5, Line 54: Note that alltypestiny is operand 0 and alltypes is operand 1. AggregationNode on top of JoinNode also needs this canonicalized operands. E.g. these two queries currently have the same HBO key string on the AggregationNode. select a.int_col, b.bigint_col, count(*) from functional.alltypes a join functional.alltypestiny b on a.id = b.id group by a.int_col, b.bigint_col; select b.int_col, a.bigint_col, count(*) from functional.alltypes a join functional.alltypestiny b on a.id = b.id group by b.int_col, a.bigint_col; I'll fix this in the next patch set. http://gerrit.cloudera.org:8080/#/c/24426/4/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java File fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java: http://gerrit.cloudera.org:8080/#/c/24426/4/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java@463 PS4, Line 463: String plainScanWithPredsER = > line too long (93 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/24426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4 Gerrit-Change-Number: 24426 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 06 Jul 2026 14:11:10 +0000 Gerrit-HasComments: Yes
