Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24426 )
Change subject: IMPALA-14601: Support HBO for JoinNode cardinality ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/24426/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24426/5//COMMIT_MSG@54 PS5, Line 54: 1) op1.id = op0.int_col > AggregationNode on top of JoinNode also needs this canonicalized operands. Done http://gerrit.cloudera.org:8080/#/c/24426/5/fe/src/main/java/org/apache/impala/analysis/SlotRef.java File fe/src/main/java/org/apache/impala/analysis/SlotRef.java: http://gerrit.cloudera.org:8080/#/c/24426/5/fe/src/main/java/org/apache/impala/analysis/SlotRef.java@344 PS5, Line 344: // grouping/output slots always have exactly one source expr, the size guard > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/24426/5/fe/src/main/java/org/apache/impala/planner/JoinNode.java File fe/src/main/java/org/apache/impala/planner/JoinNode.java: http://gerrit.cloudera.org:8080/#/c/24426/5/fe/src/main/java/org/apache/impala/planner/JoinNode.java@968 PS5, Line 968: List<PlanNode.HboKeyedNode> sortedOperands = PlanNode.buildSortedHboNodes( > line too long (109 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/24426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4 Gerrit-Change-Number: 24426 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 08 Jul 2026 14:05:10 +0000 Gerrit-HasComments: Yes
