Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24211 )
Change subject: IMPALA-14909: Calcite planner: Fix validation for views with column list ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/24211/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTable.java: http://gerrit.cloudera.org:8080/#/c/24211/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaViewTable.java@43 PS5, Line 43: private SqlNode validatedNode_; > Done Done http://gerrit.cloudera.org:8080/#/c/24211/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ViewAliasCorrector.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ViewAliasCorrector.java: http://gerrit.cloudera.org:8080/#/c/24211/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ViewAliasCorrector.java@191 PS10, Line 191: "EXPR$" Use the constant org.apache.calcite.sql.SqlUtil.GENERATED_EXPR_ALIAS_PREFIX instead of this magic string. http://gerrit.cloudera.org:8080/#/c/24211/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ViewAliasCorrector.java@211 PS10, Line 211: "EXPR$" Use the constant org.apache.calcite.sql.SqlUtil.GENERATED_EXPR_ALIAS_PREFIX instead of this magic string. -- To view, visit http://gerrit.cloudera.org:8080/24211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d0229c8907f69e648034d12fe375d9d9a384e25 Gerrit-Change-Number: 24211 Gerrit-PatchSet: 10 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 07 Jul 2026 21:06:28 +0000 Gerrit-HasComments: Yes
