Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24560 )
Change subject: IMPALA-15150: Adds missing sleep in test_runtime_filter_annotation_with_hbo_cardinality ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24560/1/tests/query_test/test_hbo.py File tests/query_test/test_hbo.py: http://gerrit.cloudera.org:8080/#/c/24560/1/tests/query_test/test_hbo.py@210 PS1, Line 210: # Wait for 1 second to ensure the stats are written to the cache. > Do we have any metric/hook or something that we can actively wait for? I th It's in the same code path that coordinator flush profile logs asynchorously in the unregistration_thread_pool: FinishUnregisterQuery -> CloseClientRequestState -> StoreExecutionStats -> ArchiveQuery I think one way is to check the profile log to see if the record of the query has been written. But we need to handle profile log rotation. If we want to check logs, checking coordinator logs would be simpler. We can add logs showing the HBO stats of a query have been written to cache. -- To view, visit http://gerrit.cloudera.org:8080/24560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c0ccc9def6d14c276d2a23403b5eae7a09849c5 Gerrit-Change-Number: 24560 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 08 Jul 2026 13:42:29 +0000 Gerrit-HasComments: Yes
