Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24560 )
Change subject: IMPALA-15150: Adds missing sleep in test_runtime_filter_annotation_with_hbo_cardinality ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24560/1/tests/query_test/test_hbo.py File tests/query_test/test_hbo.py: http://gerrit.cloudera.org:8080/#/c/24560/1/tests/query_test/test_hbo.py@210 PS1, Line 210: # Wait for 1 second to ensure the stats are written to the cache. > We could potentially add a retry loop for sleep/execute_query/assert and tr Adding a retry loop is a good idea. But it only works for possitive tests. There are some negative tests (test_failed_queries, test_cancellation) that assert HBO stats don't exist. They would always pass the first check and if we don't sleep enough time, we loose the coverage. I can make the change on possitive tests. -- To view, visit http://gerrit.cloudera.org:8080/24560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c0ccc9def6d14c276d2a23403b5eae7a09849c5 Gerrit-Change-Number: 24560 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 09 Jul 2026 05:26:01 +0000 Gerrit-HasComments: Yes
