Michael Smith has posted comments on this change. (
http://gerrit.cloudera.org:8080/24564 )
Change subject: IMPALA-15156: Use stripped rels for cost metadata
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
This wasn't sufficient for me,
tests/query_test/test_calcite_planner.py::TestCalcitePlanner::{test_cte_plans,test_cte_distributed}
still fail with "cost is still infinite."
http://gerrit.cloudera.org:8080/#/c/24564/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/24564/1//COMMIT_MSG@9
PS1, Line 9: CTE and materialized-view rewrites can cost RelSubset inputs
directly. Impala's non-cumulative cost model asks those inputs for row-count
and size metadata, but size metadata should be read from the selected or
original rel instead of from the RelSubset wrapper.
nit: please use 72 character column width for commit messages to be consistent
with the rest of our commits.
--
To view, visit http://gerrit.cloudera.org:8080/24564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide226449f7b7a33fffd67f403b03fd5b2fee53ee
Gerrit-Change-Number: 24564
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Wed, 08 Jul 2026 22:42:26 +0000
Gerrit-HasComments: Yes
