Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24564 )
Change subject: IMPALA-15156: Use stripped rels for cost metadata ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24564/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdSize.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdSize.java: http://gerrit.cloudera.org:8080/#/c/24564/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdSize.java@55 PS2, Line 55: public List<Double> averageColumnSizes(RelSubset subset, RelMetadataQuery mq) { > Since you still kept this override, what additional benefit do you see to t Removed the RelSubset size override in PS3. The cost path now unwraps subsets before requesting row-count and row-size metadata; the remaining CTE consumer/producer/sequence handlers are still needed so averageRowSize() can derive column sizes for those custom rels. -- To view, visit http://gerrit.cloudera.org:8080/24564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide226449f7b7a33fffd67f403b03fd5b2fee53ee Gerrit-Change-Number: 24564 Gerrit-PatchSet: 2 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2026 08:31:50 +0000 Gerrit-HasComments: Yes
