Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24208 )
Change subject: IMPALA-14903: Calcite planner: Simplify code for string literals ...................................................................... Patch Set 20: (2 comments) In answer to your question: I did run the full test suite for the Calcite planner, and all tests (except 4 currently broken ones for HBO) passed. However, I ran it again because of one of your new findings of two rules that were commented out that should have been there. And also, while debugging, I noticed a lot of adjacent Project RelNodes. Before this commit, I couldn't merge the Projects because we needed the Project on top of the Values clause, so I added that rule in as well. This wound up causing a lot of changes in the junit tests, but all the changes were RelNode cleanups. http://gerrit.cloudera.org:8080/#/c/24208/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/24208/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@197 PS20, Line 197: // 1.42, so these lines should be uncommented out after this upgrade. > We're now on Calcite 1.42, so can these be uncommented? Yeah, good catch, I had forgotten about this since I created this patch way before the 1.42 patch got committed. http://gerrit.cloudera.org:8080/#/c/24208/20/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q08.test File testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q08.test: http://gerrit.cloudera.org:8080/#/c/24208/20/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q08.test@140 PS20, Line 140: ImpalaFilterRel(condition=[AND(SEARCH(SUBSTR($9, 1:BIGINT, 5:BIGINT), Sarg[_UTF-8'10298':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'10374':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'10425':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'11340':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'11489':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'11618':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'11652':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'11686':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'11855':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'11912':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'12197':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'12318':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'12320':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'12350':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'13086':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'13123':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'13261':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'13338':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'13376':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'13378':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'13443':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'13844':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'13869':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'13918':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'14073':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'14155':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'14196':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'14242':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'14312':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'14440':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'14530':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'14851':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'15371':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'15475':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'15543':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'15734':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'15751':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'15782':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'15794':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'16005':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'16226':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'16364':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'16515':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'16704':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'16791':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'16891':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'17167':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'17193':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'17291':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'17672':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'17819':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'17879':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'17895':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'18218':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'18360':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'18367':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'18410':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'18421':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'18434':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'18569':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'18700':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'18767':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'18829':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'18884':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'19326':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'19444':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'19489':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'19753':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'19833':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'19988':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'20244':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'20317':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'20534':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'20601':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'20712':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'21060':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'21094':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'21204':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'21231':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'21343':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'21727':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'21800':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'21814':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'22728':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'22815':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'22911':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'23065':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'23952':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'24227':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'24255':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'24286':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'24594':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'24660':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'24891':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'24987':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'25115':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'25178':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'25214':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'25264':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'25333':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'25494':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'25717':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'25973':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'26217':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'26689':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'27052':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'27116':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'27156':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'27287':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'27369':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'27385':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'27413':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'27642':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'27700':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'28055':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'28239':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'28571':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'28577':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'28810':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'29086':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'29392':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'29450':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'29752':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'29818':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'30106':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'30415':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'30621':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'31013':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'31016':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'31655':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'31830':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'32489':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'32669':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'32754':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'32919':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'32958':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'32961':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'33113':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'33122':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'33159':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'33467':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'33562':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'33773':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'33869':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'34306':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'34473':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'34594':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'34948':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'34972':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'35076':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'35390':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'35834':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'35863':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'35926':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'36201':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'36335':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'36430':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'36479':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'37119':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'37788':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'37914':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'38353':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'38607':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'38919':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'39214':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'39459':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'39500':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'39503':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'40146':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'40936':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'40979':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'41162':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'41232':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'41255':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'41331':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'41351':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'41352':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'41419':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'41807':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'41836':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'41967':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'42361':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'43432':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'43639':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'43830':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'43933':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'44529':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'45266':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'45484':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'45533':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'45645':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'45676':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'45859':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'46081':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'46131':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'46507':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'47289':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'47369':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'47529':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'47602':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'47770':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'48017':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'48162':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'48333':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'48530':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'48567':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'49101':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'49130':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'49140':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'49211':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'49230':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'49254':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'49472':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'50412':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'50632':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'50636':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'50679':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'50788':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'51089':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'51184':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'51195':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'51634':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'51717':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'51766':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'51782':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'51793':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'51933':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'52094':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'52301':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'52389':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'52868':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'53163':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'53535':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'53565':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'54010':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'54207':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'54364':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'54558':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'54585':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'55233':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'55349':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'56224':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'56355':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'56436':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'56455':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'56600':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'56877':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'57025':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'57553':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'57631':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'57649':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'57839':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'58032':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'58058':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'58062':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'58117':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'58218':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'58412':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'58454':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'58581':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'59004':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'59080':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'59130':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'59226':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'59345':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'59386':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'59494':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'59852':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'60083':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'60298':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'60560':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'60624':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'60736':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'61527':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'61794':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'61860':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'61997':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'62361':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'62585':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'62878':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'63073':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'63180':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'63193':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'63294':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'63792':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'63991':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'64592':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'65148':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'65177':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'65501':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'66057':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'66943':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'67881':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'67975':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'67998':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'68101':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'68293':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'68341':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'68605':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'68730':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'68770':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'68843':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'68852':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'68908':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'69280':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'69952':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'69998':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'70041':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'70070':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'70073':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'70450':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'71144':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'71256':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'71286':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'71836':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'71948':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'71954':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'71997':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'72592':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'72991':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'73021':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'73108':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'73134':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'73146':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'73219':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'73873':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'74686':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'75660':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'75675':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'75742':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'75752':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'77454':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'77817':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'78093':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'78366':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'79077':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'79658':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'80332':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'80846':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'81003':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'81070':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'81084':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'81335':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'81504':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'81755':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'81963':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'82080':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'82602':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'82620':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'83041':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'83086':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'83583':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'83647':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'83833':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'83910':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'83986':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'84247':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'84680':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'84844':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'84919':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'85066':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'85761':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'86057':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'86379':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'86709':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'88086':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'88137':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'88217':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'89193':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'89338':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'90209':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'90229':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'90669':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'91110':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'91894':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'92292':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'92380':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'92645':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'92696':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'93498':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'94791':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'94835':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'94898':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'95042':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'95430':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'95464':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'95694':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'96435':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'96560':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'97173':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'97462':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'98069':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'98072':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'98338':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'98533':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'98569':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'98584':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'98862':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'99060':VARCHAR(2147483647) CHARACTER SET "UTF-8", _UTF-8'99132':VARCHAR(2147483647) CHARACTER SET "UTF-8"; NULL AS FALSE]:VARCHAR(2147483647) CHARACTER SET "UTF-8"), IS NOT NULL(SUBSTR(SUBSTR($9, 1:BIGINT, 5:BIGINT), 1:BIGINT, 2:BIGINT)))]) > This seems kind of awkward. Yeah, definitely awkward, so I traced why this is here... The JoinPushTransitivePredicates rule was the rule that creates this extra filter expression. I'm guessing it didn't kick in before because of the Project on top of the Values. Regardless, it seems like this extra filter is a good thing as it eliminates a lot of the customer address rows before the join takes place. The query itself is awkward because of the hundreds of zip codes in the IN clause, so this seems to be ok. -- To view, visit http://gerrit.cloudera.org:8080/24208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8e61b2555afd81ef52f19431fdd1224d4039c00 Gerrit-Change-Number: 24208 Gerrit-PatchSet: 20 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 09 Jul 2026 13:22:28 +0000 Gerrit-HasComments: Yes
