Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24208 )

Change subject: IMPALA-14903: Calcite planner: Simplify code for string literals
......................................................................


Patch Set 21: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24208/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java
File 
java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java:

http://gerrit.cloudera.org:8080/#/c/24208/20/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@197
PS20, Line 197:         ImpalaCoreRules.PROJECT_VALUES_MERGE,
> Yeah, good catch, I had forgotten about this since I created this patch way
Ack



--
To view, visit http://gerrit.cloudera.org:8080/24208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e61b2555afd81ef52f19431fdd1224d4039c00
Gerrit-Change-Number: 24208
Gerrit-PatchSet: 21
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Thu, 09 Jul 2026 18:55:31 +0000
Gerrit-HasComments: Yes

Reply via email to