Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24137 )
Change subject: IMPALA-13810: Generate lineage records for UPDATE and MERGE statements ...................................................................... Patch Set 16: Code-Review+1 (2 comments) Two small comments, otherwise LGTM! http://gerrit.cloudera.org:8080/#/c/24137/16/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/24137/16/fe/src/main/java/org/apache/impala/planner/Planner.java@369 PS16, Line 369: Preconditions.checkState(kuduUpdateColIdxs.size() == outputExprs.size(), : "Kudu UPDATE lineage: target col idxs (%s) and output exprs (%s) size " : + "mismatch", kuduUpdateColIdxs.size(), outputExprs.size()); Do we need to nest this check inside an if-stmt? http://gerrit.cloudera.org:8080/#/c/24137/16/fe/src/main/java/org/apache/impala/planner/Planner.java@396 PS16, Line 396: getRawPath(); : String columnName = rawPath.get(rawPath.size() - 1); Can we use 'destColumn().getPosition()' instead? Like how we do at L506. -- To view, visit http://gerrit.cloudera.org:8080/24137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icba79f756509438455bfbf3067733f6f29284220 Gerrit-Change-Number: 24137 Gerrit-PatchSet: 16 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 09 Jul 2026 14:33:19 +0000 Gerrit-HasComments: Yes
