Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/24137 )
Change subject: IMPALA-13810: Generate lineage records for UPDATE and MERGE statements ...................................................................... Patch Set 17: (2 comments) Also cleaned up a couple other discrepencies. http://gerrit.cloudera.org:8080/#/c/24137/16/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/24137/16/fe/src/main/java/org/apache/impala/planner/Planner.java@369 PS16, Line 369: for (int i = 0; i < kuduUpdateColIdxs.size(); ++i) { : Column col = kuduUpdateColumns.get(kuduUpdateColIdxs.get(i)); : String columnName = col.getName(); > Do we need to nest this check inside an if-stmt? Nope, unnested it. http://gerrit.cloudera.org:8080/#/c/24137/16/fe/src/main/java/org/apache/impala/planner/Planner.java@396 PS16, Line 396: (); : int colIdx = col.getPosition(); > Can we use 'destColumn().getPosition()' instead? Like how we do at L506. Done -- To view, visit http://gerrit.cloudera.org:8080/24137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icba79f756509438455bfbf3067733f6f29284220 Gerrit-Change-Number: 24137 Gerrit-PatchSet: 17 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2026 16:38:24 +0000 Gerrit-HasComments: Yes
