Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24513 )
Change subject: IMPALA-15061: Refactor and Improve IcebergFileMetadataLoader ...................................................................... Patch Set 3: Code-Review+1 (4 comments) Nice work! http://gerrit.cloudera.org:8080/#/c/24513/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24513/3//COMMIT_MSG@53 PS3, Line 53: FiletadataLoaderTest typo: FileMetadataLoaderTest http://gerrit.cloudera.org:8080/#/c/24513/3/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/24513/3/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@73 PS3, Line 73: occured typo: occurred http://gerrit.cloudera.org:8080/#/c/24513/3/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@240 PS3, Line 240: new ByteBuffer[oldIcebergPartitions_.size()]; : for (Map.Entry<ByteBuffer, Integer> entry : oldIcebergPartitions_.entrySet()) { : oldPartitionById[entry.getValue()] = entry.getKey(); : } Could we use IcebergContentFileStore.convertPartitionMapToList(oldIcebergPartitions_, 0)? http://gerrit.cloudera.org:8080/#/c/24513/3/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@503 PS3, Line 503: boolean incremental, : boolean noRemovedPartitions nit: The constructor gets the LoadingMode as a parameter, while this static method deduces it from two boolean parameters. I think it would be better to have a consistent set of parameters. -- To view, visit http://gerrit.cloudera.org:8080/24513 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3faa45a311385c65a7e2ec7f46e3305c5de2ee0b Gerrit-Change-Number: 24513 Gerrit-PatchSet: 3 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 09 Jul 2026 16:36:21 +0000 Gerrit-HasComments: Yes
