Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24513 )
Change subject: IMPALA-15061: Refactor and Improve IcebergFileMetadataLoader ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/24513/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24513/3//COMMIT_MSG@7 PS3, Line 7: I nit: improve http://gerrit.cloudera.org:8080/#/c/24513/3//COMMIT_MSG@19 PS3, Line 19: can operate in different modes during a metadata refresh, What do you think about creating 3 strategy classes that handle the 3 different modes? http://gerrit.cloudera.org:8080/#/c/24513/3/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/24513/3/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@184 PS3, Line 184: private void initPartitionId() { : if (mode_ == LoadingMode.INCREMENTAL || mode_ == LoadingMode.NO_REMOVED_PARTITIONS) { : loadedIcebergPartitions_.putAll(oldIcebergPartitions_); > naming: initPartitions? loadedIcebergPartitions_ is also modified nit: switch-case with a fallthrough? -- To view, visit http://gerrit.cloudera.org:8080/24513 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3faa45a311385c65a7e2ec7f46e3305c5de2ee0b Gerrit-Change-Number: 24513 Gerrit-PatchSet: 3 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2026 11:13:52 +0000 Gerrit-HasComments: Yes
