Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )
Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE ...................................................................... Patch Set 10: (3 comments) I addressed Michael's comments on patch set 9. Let me know if there are additional suggestions. Thanks! http://gerrit.cloudera.org:8080/#/c/24315/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/24315/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@182 PS9, Line 182: User requestingUser = new User(header.getRequesting_user()); > Do we need to verify getRequesting_user is set? Previously we had that as a Yes, you are correct. I will add a Preconditions.checkNotNull(requestingUser) here in the next patch. http://gerrit.cloudera.org:8080/#/c/24315/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@205 PS9, Line 205: plugin_.get().revokeRole(request, /*resultProcessor*/ null); > typo: because Done http://gerrit.cloudera.org:8080/#/c/24315/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@667 PS9, Line 667: > This is a typo. I will correct it in the next patch. Done -- To view, visit http://gerrit.cloudera.org:8080/24315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61 Gerrit-Change-Number: 24315 Gerrit-PatchSet: 10 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2026 19:23:29 +0000 Gerrit-HasComments: Yes
