Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )
Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/24315/10/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java File fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java: http://gerrit.cloudera.org:8080/#/c/24315/10/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@139 PS10, Line 139: public void testRevokeRoleAuditEvents() throws Exception { > This unit test relies on the testGrantRoleAuditEvents having been run first Thanks for pointing this out Jason! I ran the following alone and found that testRevokeRoleAuditEvents() could run without testGrantRoleAuditEvents having been run first. (pushd fe && mvn test -Dtest=RangerCatalogdAuthorizationManagerTest#testRevokeRoleAuditEvents) I think the reason is that as long as the role TEST_ROLE exists, even though this role is not granted to REVOKEE_USER or REVOKEE_GROUP, Ranger server would not complain after receiving such a request (e.g., "REVOKE ROLE test_role FROM USER non_owner") from Impala's Ranger plug-in. On the other hand, we do have to make sure TEST_ROLE exists before running this test method. We guarantee this by setUpTest() at https://gerrit.cloudera.org/c/24315/10/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java#76. Let me know if I missed something. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/24315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61 Gerrit-Change-Number: 24315 Gerrit-PatchSet: 10 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2026 22:57:51 +0000 Gerrit-HasComments: Yes
