Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/24528 )
Change subject: IMPALA-15135: Calcite planner: added support for Kudu tables ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/24528/11/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java: http://gerrit.cloudera.org:8080/#/c/24528/11/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@83 PS11, Line 83: count(*) is called For count(*) we don't need to project all columns. Did you mean SELECT * ? http://gerrit.cloudera.org:8080/#/c/24528/11/fe/src/main/java/org/apache/impala/catalog/FeTable.java File fe/src/main/java/org/apache/impala/catalog/FeTable.java: http://gerrit.cloudera.org:8080/#/c/24528/11/fe/src/main/java/org/apache/impala/catalog/FeTable.java@130 PS11, Line 130: count(*) is called Same comment as above regarding count(*) http://gerrit.cloudera.org:8080/#/c/24528/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java: http://gerrit.cloudera.org:8080/#/c/24528/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@131 PS11, Line 131: null About the null agInfo, I understand we are not passing it for the scans .. but what type of optimization would be excluded if we don't ? http://gerrit.cloudera.org:8080/#/c/24528/11/testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test File testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test: http://gerrit.cloudera.org:8080/#/c/24528/11/testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test@316 PS11, Line 316: # IMPALA-15134: Calcite planner produces different cardinality estimate. This description does not seem correct because the 7.3K vs 1.82K difference is in the actual SCAN cardinality, not the estimated cardinality. Isn't the discrepancy due to the runtime filters ? Is runtime filters getting generated for the Kudu scan ? -- To view, visit http://gerrit.cloudera.org:8080/24528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie22a66f0edad195cade74a8447efc83a8ce526f7 Gerrit-Change-Number: 24528 Gerrit-PatchSet: 11 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Sat, 11 Jul 2026 18:08:13 +0000 Gerrit-HasComments: Yes
