Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24528 )
Change subject: IMPALA-15135: Calcite planner: added support for Kudu tables ...................................................................... Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/24528/11/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java: http://gerrit.cloudera.org:8080/#/c/24528/11/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@88 PS11, Line 88: default List<Column> getStarColumns() { Does it need to return a List? Lazy iteration would be nice. http://gerrit.cloudera.org:8080/#/c/24528/11/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@89 PS11, Line 89: return getColumnsInHiveOrder().stream() https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java#L905-L908 has similar logic. I believe isHidden is primarily for some Iceberg columns. It might be nice to use this helper in SelectStmt. http://gerrit.cloudera.org:8080/#/c/24528/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java: http://gerrit.cloudera.org:8080/#/c/24528/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@292 PS11, Line 292: if (!canConvertIcebergPredicate(icebergTable.getFeIcebergTable(),conjunct, nit: spacing after ',' -- To view, visit http://gerrit.cloudera.org:8080/24528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie22a66f0edad195cade74a8447efc83a8ce526f7 Gerrit-Change-Number: 24528 Gerrit-PatchSet: 13 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Mon, 13 Jul 2026 17:50:29 +0000 Gerrit-HasComments: Yes
