Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/24559 )
Change subject: IMPALA-12700: Take Iceberg Parquet Bloom filter properties into account ...................................................................... Patch Set 2: (2 comments) Just some initial thoughts on testing. http://gerrit.cloudera.org:8080/#/c/24559/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: http://gerrit.cloudera.org:8080/#/c/24559/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@794 PS2, Line 794: if (IcebergUtil.hasParquetBloomFilterProperties(getTblProperties()) : && icebergFileFormat != TIcebergFileFormat.PARQUET) { : throw new AnalysisException( : "Parquet Bloom filter properties should be set only for parquet file format") nit: This can also be tested if it is not too complicated. http://gerrit.cloudera.org:8080/#/c/24559/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test: http://gerrit.cloudera.org:8080/#/c/24559/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test@643 PS2, Line 643: CREATE TABLE iceberg_wrong_bloom_max_bytes1 (i int) : STORED AS ICEBERG : TBLPROPERTIES('write.format.default'='orc', : 'write.parquet.bloom-filter-enabled.column.i'='true'); : ---- CATCH : Parquet Bloom filter properties should be set only for parquet file format Move these tests into the respective AnalyzerTest (L643) and ParserTest (L651-L702) files instead. -- To view, visit http://gerrit.cloudera.org:8080/24559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7baab79bbc055ddc8e2b05bbbc7083e02dc914e Gerrit-Change-Number: 24559 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Mon, 13 Jul 2026 09:59:32 +0000 Gerrit-HasComments: Yes
