Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24558 )
Change subject: IMPALA-15019: Avoid materializing non-projected filtered partition column. ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/24558/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java: http://gerrit.cloudera.org:8080/#/c/24558/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@129 PS6, Line 129: // Optimization for parititoned scan node columns that are not used in > typo: partitioned Done http://gerrit.cloudera.org:8080/#/c/24558/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@250 PS6, Line 250: List<RexNode> projects) { > projects argument is unused, looks like you instead call getProjects() agai Done http://gerrit.cloudera.org:8080/#/c/24558/6/testdata/workloads/functional-query/queries/QueryTest/hbo-multiple-scans.test File testdata/workloads/functional-query/queries/QueryTest/hbo-multiple-scans.test: http://gerrit.cloudera.org:8080/#/c/24558/6/testdata/workloads/functional-query/queries/QueryTest/hbo-multiple-scans.test@149 PS6, Line 149: # query is from a join and an added "id is not null" predicate > Is this something HBO might want to address later? Maybe? I'm not quite sure how we want to handle this. It's not like there's anything wrong with the code or the test. It's working as designed. It's just the framework of the test produces a different predicate for the original planner. I don't think there's any plan to change the original planner to add the more optimal "is not null" predicate either. If you think I should file a Jira, I will. -- To view, visit http://gerrit.cloudera.org:8080/24558 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I902dc625963321aff57e5c05af3d1137c06aa882 Gerrit-Change-Number: 24558 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Mon, 13 Jul 2026 17:22:36 +0000 Gerrit-HasComments: Yes
