Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24558 )

Change subject: IMPALA-15019: Avoid materializing non-projected filtered 
partition column.
......................................................................


Patch Set 7: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24558/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java
File 
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java:

http://gerrit.cloudera.org:8080/#/c/24558/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@250
PS6, Line 250:       List<RexNode> projects) {
> Done
Ack


http://gerrit.cloudera.org:8080/#/c/24558/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java
File 
java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java:

http://gerrit.cloudera.org:8080/#/c/24558/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@263
PS6, Line 263:    * ProjectMerge: The RelFieldTrimmer adds some extra Projects 
that need
> Comment still mentions FILTER_PROJECT_TRANSPOSE.
Done



--
To view, visit http://gerrit.cloudera.org:8080/24558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I902dc625963321aff57e5c05af3d1137c06aa882
Gerrit-Change-Number: 24558
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Reviewer: Xuebin Su <[email protected]>
Gerrit-Comment-Date: Mon, 13 Jul 2026 17:52:23 +0000
Gerrit-HasComments: Yes

Reply via email to