Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24552 )
Change subject: POC IMPALA-15165: Add minimal C++ WKB serialization support ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/24552/6/be/src/exprs/geo/wkb-serialization.cc File be/src/exprs/geo/wkb-serialization.cc: http://gerrit.cloudera.org:8080/#/c/24552/6/be/src/exprs/geo/wkb-serialization.cc@272 PS6, Line 272: poly.outer().emplace_back(xmin, ymin); : poly.outer().emplace_back(xmax, ymin); : poly.outer().emplace_back(xmax, ymax); : poly.outer().emplace_back(xmin, ymax); : poly.outer().emplace_back(xmin, ymin); Is there a reason for this being counter-clockwise? polygon2d is defined as clockwise: using polygon2d = bg::model::polygon<point2d, true>; so this is a reverse-oriented polygon (not sure if that's intended or not) -- To view, visit http://gerrit.cloudera.org:8080/24552 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d5b2ac5d584e3de7712d8471acbc07d743a4de2 Gerrit-Change-Number: 24552 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 15 Jul 2026 08:39:11 +0000 Gerrit-HasComments: Yes
